D7979: Filter out warnings as error from parser's compile flags
Milian Wolff
noreply at phabricator.kde.org
Tue Sep 26 08:01:16 UTC 2017
mwolff requested changes to this revision.
mwolff added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> parsesession.cpp:68
>
> +QVector<QByteArray> sanitizeArguments(const QVector<QByteArray>& dirtyArguments) {
> + QVector<QByteArray> arguments;
move { to its own line
> parsesession.cpp:71
> +
> + std::copy_if(
> + std::make_move_iterator(dirtyArguments.begin()),
this should use QVector::erase + std::remove_if on a mutable container
REPOSITORY
R32 KDevelop
REVISION DETAIL
https://phabricator.kde.org/D7979
To: gracicot, #kdevelop, kfunk, mwolff
Cc: mwolff, brauch, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170926/7c5d4b39/attachment.html>
More information about the KDevelop-devel
mailing list