D5447: Only add auto-detected compilers to model if they actually exist

[Kevin Funk]

kfunk requested changes to this revision.
kfunk added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> skalinichev wrote in compilerfactories.cpp:44-46
> It doesn't seem right, we already perform that check in CompilerProvider::CompilerProvider

Indeed. That part seems unnecessary.

The change above looks sane, though. The second parameter passed to `createCompiler` is the *path*, not the *name*, so a fully-qualified path should be passed here.

Maybe we should pass the path as argument to this function instead? Seems more clean to me.

@arichardson Care to double-check?

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D5447

To: arichardson, mwolff, kfunk
Cc: skalinichev, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170925/25b0b198/attachment.html>