D7930: Kdevelop CMake plugin : use canonical paths to build.dir

[René J.V. Bertin]

rjvbb marked an inline comment as done.
rjvbb added a comment.


  F3921734: patch-KDevelopPath=canonical.diff <https://phabricator.kde.org/F3921734>
  
  This is a draft, PoC implementation that should make KDevelop::Path work with canonical paths, by converting them on input. It just leaves the final symlink if that is a file, so symlink shortcuts to executables are not replaced with the target.
  
  Making KDevelop::Path purely canonical indeed makes the cmake patch redundant but has an interesting side-effect. The parser now complains about undefined logging category symbols (`CMAKE` in the cmake plugin), and from the looks of it that is because it finds the kdevplatform/project/debug.h headerfile before it finds the correct debug.h headerfile.
  
  This PoC patch isn't cheap, btw, judging from how much it slows down the test_path unittest. I'd be curious to know how to make it more efficient, esp. how better to handle the 2nd canonicalisation in addPath().

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D7930

To: rjvbb, #kdevelop, apol
Cc: mwolff, apol, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170922/84fa9113/attachment.html>