D7742: KDevelop projects: optional use of KDirWatch and defer it and parser start to after project loading

René J.V. Bertin noreply at phabricator.kde.org
Mon Sep 18 20:12:11 UTC 2017


rjvbb updated this revision to Diff 19654.
rjvbb marked 2 inline comments as done.
rjvbb edited the test plan for this revision.
rjvbb added a comment.


  This revision incorporates the suggested changes to AbstractFileManagerPlugin the project load timer and IProjectFileManager (instead of IProject).
  
  I've made the dirwatcher checkbox visible only on Mac due to the apparent consensus that KDirWatch has negligible cost on Linux. The cost (on Mac) comes entirely from the single call to KDirWatch::addDir and is thus independent from any performance bugs in KDevelop's project loading; this justifies the proposition to defer the dirwatcher creation IMHO.

REPOSITORY
  R32 KDevelop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7742?vs=19343&id=19654

REVISION DETAIL
  https://phabricator.kde.org/D7742

AFFECTED FILES
  interfaces/iprojectcontroller.cpp
  interfaces/iprojectcontroller.h
  project/abstractfilemanagerplugin.cpp
  project/abstractfilemanagerplugin.h
  project/interfaces/iprojectfilemanager.h
  shell/projectcontroller.cpp
  shell/settings/projectconfig.kcfg
  shell/settings/projectpreferences.cpp
  shell/settings/projectpreferences.ui

To: rjvbb, #kdevelop, mwolff, brauch
Cc: mwolff, kossebau, arrowdodger, brauch, zhigalin, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170918/55d176dc/attachment-0001.html>


More information about the KDevelop-devel mailing list