D7752: Make it possible for IBuildSystem to provide extra arguments to the parser

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> qmakeprojectfile.cpp:292
> +{
> +    const QVector<QString> variablesToCheck = {QStringLiteral("QMAKE_CXXFLAGS")};
> +    const QVector<QLatin1String> prefixes = { QLatin1String("-F"), QLatin1String("-iframework"), QLatin1String("-I"), QLatin1String("-D") };

You could use initializer_list here to obsolete the memory allocation for the vector:

  const auto variablesToCheck = {...};
  const auto prefixes = {...};

> qmakeprojectfile.cpp:293
> +    const QVector<QString> variablesToCheck = {QStringLiteral("QMAKE_CXXFLAGS")};
> +    const QVector<QLatin1String> prefixes = { QLatin1String("-F"), QLatin1String("-iframework"), QLatin1String("-I"), QLatin1String("-D") };
> +    QStringList args;

isn't `-isystem` still missing?

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D7752

To: apol, #kdevelop, kfunk, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170913/1d5bf15c/attachment.html>