D7752: Make it possible for IBuildSystem to provide extra arguments to the parser

[Aleix Pol Gonzalez]

apol marked 8 inline comments as done.
apol added inline comments.

INLINE COMMENTS

> mwolff wrote in qmakeprojectfile.cpp:292
> imo it should be either CFLAGS or CXXFLAGS, not a combination of the two which could lead really funky combinations that would break in magic ways... Could you maybe check at the callee site whether we are interested in C or C++ flags?

Meh, we're passing it to clang, in fact it's what clang will use to figure out if to use c++ or c parsing. I'll change to just use CXXFLAGS and it will already be better than the status quo.

> mwolff wrote in qmakeprojectfile.cpp:295
> `-isystem` too? And is it really "-F" or did you mean "-D"?

Yeah, actually what I meant to do here was to filter these out.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D7752

To: apol, #kdevelop, kfunk, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170912/d57a2777/attachment.html>