D7693: Enable reproducible packaging of template archives

[Aaron Puchert]

aaronpuchert added a comment.


  I see you already submitted the change, but you omitted `--sort=name`.
  
  Was that oversight, or is there a reason for that?

INLINE COMMENTS

> kfunk wrote in KDevPlatformMacros.cmake:65
> Can you refactor this so you don't need another `add_custom_command` call?
> 
> i.e. put this in the else() branch:
> 
>   set(extraArgs "")
>   if (DEFINED ENV{...})
>      set(extraArgs "--mtime=...")
>   endif()
>   add_custom_command(...
>     ... ${extraArgs} ...
> 
> )

Yes, that's probably a good idea.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D7693

To: aaronpuchert, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170905/6b810f30/attachment.html>