D7693: Enable reproducible packaging of template archives

[Kevin Funk]

kfunk requested changes to this revision.
kfunk added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> KDevPlatformMacros.cmake:65
>              )
> +        elseif(DEFINED ENV{SOURCE_DATE_EPOCH})
> +            # We assume there is tar > 1.28 if a reproducible build is wanted.

Can you refactor this so you don't need another `add_custom_command` call?

i.e. put this in the else() branch:

  set(extraArgs "")
  if (DEFINED ENV{...})
     set(extraArgs "--mtime=...")
  endif()
  add_custom_command(...
    ... ${extraArgs} ...

)

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D7693

To: aaronpuchert, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170904/e0192a83/attachment.html>