D8508: Make kdev{debuggercommon, gdb, lldb} compile under Windows.

[Kevin Funk]

kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.


  Rest LGTM, very nice Gleb! You rock :)

INLINE COMMENTS

> midebugger.cpp:115
> +#else
> +    SetConsoleCtrlHandler(NULL, TRUE);
> +    GenerateConsoleCtrlEvent(0, 0);

`NULL` -> `nullptr`, `TRUE` -> `true`, etc.

> debugeethreads.cpp:31
>      void run() override {
>          sleep(1);
>          std::cout << "Hello, world!" << std::endl;

Not sure if the tests depend on that `sleep(...)` call, but if they don't you could just use `QThread::usleep(...)`

REPOSITORY
  R32 KDevelop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8508

To: arrowdodger, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171027/5f0204a2/attachment-0001.html>