D8059: KDevelop: abstractfilemanagerimport benchmark

Milian Wolff noreply at phabricator.kde.org
Thu Oct 26 09:16:03 UTC 2017

mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.

  please fix the nit, then feel free to commit to master branch. Note again that the commit message should include your measurements you posted above.
  Otherwise, it's interesting to see that QFSWatcher takes so much more CPU time, this should really be profiled and fixed upstream.


> abstractfilemanagerpluginimportbenchmark.cpp:49
> +    AbstractFileManagerPluginImportBenchmark(AbstractFileManagerPlugin* manager, const QString& path,
> +        QObject* parent)
> +        : QObject(parent)

align with the `(` in the line above

  R32 KDevelop


To: rjvbb, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171026/24c7b080/attachment.html>

More information about the KDevelop-devel mailing list