D8059: KDevelop: abstractfilemanagerimport benchmark

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> abstractfilemanagerplugin.cpp:494
>      if ( project->path().isLocalFile() ) {
> -        d->m_watchers[project] = new KDirWatch( project );
> +        auto watcher = new KDirWatch( project );
>  

this part of the patch (i.e. introducing the temporary and referencing it instead of looking it up repeatedly in `m_watchers`) is fine, but unrelated to this patch. Please commit it separately.

> abstractfilemanagerpluginimportbenchmark.cpp:48
> +public:
> +    AbstractFileManagerPluginImportBenchmark(AbstractFileManagerPlugin* manager, const QString& path, QObject* parent)
> +        : QObject(parent)

break long line, add newline after path,

> abstractfilemanagerpluginimportbenchmark.cpp:59
> +        m_projectNumber = s_numBenchmarksRunning++;
> +        m_out << "Starting import of project " << m_project->path().toLocalFile() << "\n";
> +        m_out.flush();

instead of using `"\n"; m_out.flush()`, use `<< endl;` which achieves the same

> abstractfilemanagerpluginimportbenchmark.cpp:68
> +        auto import = m_manager->createImportJob(root);
> +        QObject::connect(import, &KJob::finished, this, &AbstractFileManagerPluginImportBenchmark::projectImportDone);
> +        m_timer.restart();

remove `QObject::` prefix, break long line by adding a newline before `this,`

> abstractfilemanagerpluginimportbenchmark.cpp:159
> +
> +

excess newline

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D8059

To: rjvbb, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171024/fe33b9e0/attachment-0001.html>