D8211: KDevelop/Documentation : implementation of a QTextBrowser-based viewer

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> standarddocumentationview.h:74
> +     */
> +    virtual bool loadResource(int type, QUrl& url, QVariant& content);
> +

Why is this method not in #ifdef USE_QTEXTBROWSER?

> standarddocumentationview.h:76
> +
> +#ifdef USE_QTEXTBROWSER
> +    /**

KDevelop::StandardDocumentationView is part of the public KDevPlatformDocumentation API,  standarddocumentationview.h is an installed header.

Having a part of the public API only created depending on build-time config settings needs this settings also be deployed with the installed headers.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D8211

To: rjvbb, #kdevelop
Cc: kossebau, aaronpuchert, flherne, arichardson, apol, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171019/b04a39ba/attachment-0001.html>