D8317: Don't try to guess the language from given arguments

[Aleix Pol Gonzalez]

apol added a comment.


  Makes sense I guess, but I'm not sure what we get...

INLINE COMMENTS

> icompiler.h:42
> +
> +    Other = 100
> +};

Make `Other` the first, this way you don't have to add this random ` = 100` there if you want.

> test_compilerprovider.cpp:127
> +    QVERIFY(!compiler->defines(Utils::Cpp, QStringLiteral("-std=c++11")).isEmpty());
> +    QVERIFY(!compiler->includes(Utils::Cpp, QStringLiteral("-std=c++11")).isEmpty());
>  }

why did you remove 1 of de dashes?

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D8317

To: aaronpuchert, #kdevelop
Cc: apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171015/8aaffb3f/attachment-0001.html>