D8317: Don't try to guess the language from given arguments

Aaron Puchert noreply at phabricator.kde.org
Sun Oct 15 20:31:45 UTC 2017


aaronpuchert created this revision.
aaronpuchert added a reviewer: KDevelop.

REVISION SUMMARY
  Before this change, the compiler provider looked up the arguments for a
  given language, and passed those to the compiler, where the language was
  guessed from the arguments.
  
  Instead we now pass the language together with the arguments into the
  function, and no more guessing is needed. Besides being cleaner, it may
  not always be possible to guess the language from the given arguments
  anyway.

REPOSITORY
  R32 KDevelop

BRANCH
  dont-guess-language

REVISION DETAIL
  https://phabricator.kde.org/D8317

AFFECTED FILES
  plugins/custom-definesandincludes/compilerprovider/compilerprovider.cpp
  plugins/custom-definesandincludes/compilerprovider/gcclikecompiler.cpp
  plugins/custom-definesandincludes/compilerprovider/gcclikecompiler.h
  plugins/custom-definesandincludes/compilerprovider/icompiler.h
  plugins/custom-definesandincludes/compilerprovider/msvccompiler.cpp
  plugins/custom-definesandincludes/compilerprovider/msvccompiler.h
  plugins/custom-definesandincludes/compilerprovider/settingsmanager.h
  plugins/custom-definesandincludes/compilerprovider/tests/test_compilerprovider.cpp

To: aaronpuchert, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171015/ca0eda3a/attachment.html>


More information about the KDevelop-devel mailing list