D8215: Added support for STRINGS property in CMake cache editor

Kevin Funk noreply at phabricator.kde.org
Mon Oct 9 16:21:09 UTC 2017


kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.


  LGTM.
  
  Now if someone is willing to refactor this code to use a) enums instead of magic numbers, b) `QAbstractItemModel` instead of `QStandardItemModel` that'd be great!

REPOSITORY
  R32 KDevelop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8215

To: gracicot, #kdevelop, kfunk
Cc: apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171009/990d6a20/attachment.html>


More information about the KDevelop-devel mailing list