D8158: KDevelop: decorate patch version string in development builds

[René J.V. Bertin]

rjvbb added inline comments.

INLINE COMMENTS

> kfunk wrote in CMakeLists.txt:133
> > We're not overwriting anything, we're adding an additional full version string. That's not unheard of, this is exactly what's done in Apple's Info.plist files. A "numeric" version for use in code, and a human-readable string that is to be presented to users.
> 
> You're basically overwriting/invalidating the `major.minor.patch` version which was previously shown in the About dialog as set by CMake.
> 
> > I can achieve the same thing the way Krita does things, but that's more complicated (cf. the script I used in the initial release). Sven pointed out that we cannot change VERSION_PATCH because that variable is used by dependent code.
> 
> It's not more complicated. Please forget about Krita again, it probably only confuses you.
> 
> And where did I talk about changing VERSION_PATCH?
> 
> `set(KDevelop_FULLVERSION_STRING "${KDEVELOP_VERSION_STRING} (git ${SHA1}")` doesn't "change" VERSION_PATCH.
> 
> > Whatever approach I will use I find it crucial that the output from git describe is used. Git hashes are random, so using only them will not allow checking at a glance which of two versions is older or newer (and that's part of what I want to achieve with this patch).
> 
> Okay, then please use:
> `set(KDevelop_FULLVERSION_STRING "${KDEVELOP_VERSION_STRING} (git ${GIT_FULL_VERSION}")`
> 
> That'll show e.g. '5.1.2' twice, but that doesn't harm.

I interpreted `re-use VERSION_MAJOR, VERSION_MINOR, VERSION_PATCH` to suggest that the fuller version should be obtained from them directly.

I'll play with `string replace`, it should be possible to remove `${MAJOR}.${MINOR}.${PATCH}` from the `git describe` return. That way the full version won't show 5.x.y twice if the version from the CMake version agrees with the current tag. Duplicate may not harm but avoiding them is more elegant, don't you think?

> kfunk wrote in GetGitRevisionDescription.cmake:1
> Hm?
> 
> I was asking you to update the copy of those GetGit*.cmake files. What does that have to do with KDevelop's 5.2 branch?

My bad, I read too quickly. But then I also don't understand why you're getting an error and I don't.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D8158

To: rjvbb, #kdevelop, brauch, kfunk
Cc: kossebau, flherne, mwolff, brauch, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171008/4867664f/attachment.html>