D8158: KDevelop: decorate patch version string in development builds

René J.V. Bertin noreply at phabricator.kde.org
Sun Oct 8 08:49:30 UTC 2017


rjvbb updated this revision to Diff 20464.
rjvbb added a comment.


  This version moves the new version string macro to a dedicated headerfile which is included only in the single file using it (app/main.cpp). This avoids unnecessary rebuilds.
  (main.cpp is quite big, is it worth the trouble moving the KAboutData set-up to a dedicated file?)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8158?vs=20405&id=20464

REVISION DETAIL
  https://phabricator.kde.org/D8158

AFFECTED FILES
  CMakeLists.txt
  app/main.cpp
  cmake/modules/GetGitRevisionDescription.cmake
  cmake/modules/GetGitRevisionDescription.cmake.in
  kdevelop-fullversion.h.cmake

To: rjvbb, #kdevelop, brauch, kfunk
Cc: kossebau, flherne, mwolff, brauch, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171008/5a7eecd3/attachment.html>


More information about the KDevelop-devel mailing list