D7979: Filter out warnings as error from parser's compile flags

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.


  I'll clean this up and commit it to 5.2, thanks!

INLINE COMMENTS

> parsesession.cpp:76
> +        } else {
> +            const auto asError = QByteArrayLiteral("-Werror=");
> +            int index = argument.indexOf(asError);

move out of the loop

> parsesession.cpp:77
> +            const auto asError = QByteArrayLiteral("-Werror=");
> +            int index = argument.indexOf(asError);
> +            if (index == 0) {

`startsWith`

> parsesession.cpp:79
> +            if (index == 0) {
> +                argument.remove(2, asError.length() - 2);
> +            }

add a comment:

  // replace -Werror=foo with -Wfoo

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D7979

To: gracicot, #kdevelop, kfunk, mwolff, brauch
Cc: mwolff, brauch, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171004/2f9dc965/attachment.html>