D8140: Always create Documentation tool view, fix it to work with no providers
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Wed Oct 4 14:21:14 UTC 2017
kossebau created this revision.
kossebau added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel.
Creating the Documentation tool view at DocumentationController
initialization time only if the list returned by documentationProviders() is
non-empty has some flaws:
1. The QtHelp plugin delays initialization to after reaching the event loop.
So if it is the only documentation provider (provider) plugin activated, it
will return 0 providers in the beginning.
2. It ignores the option that users can enable another documentation provider plugin
3. There is also no code for removing the tool view in case the user
disables any documentation providers at runtime.
4. It ignores the option of plugins like the QtHelp one allowing the user to
disable any documentation providers at runtime.
This patch always creates the toolview instead of magically creating/removing it
automatically based on documentation provider availability and leaves it to
the user to add or remove it as they prefer.
It also prepares the Documentation tool view to properly handle the case of
no documentation providers available (done in a way to keep the current public
To: kossebau, #kdevelop
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel