D9063: Add file templ: QObject, QAbstractItemModel, QWidget, QDialog (pimpl & not)

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Thu Nov 30 01:19:29 UTC 2017

kossebau added a comment.

  Code generation with file templates sadly has regressed a little again with 5.2, so results are not yet perfect::
  a) Abstract virtual methods are not generated as overriding, but still abstract (since 5.2)
  b) Some template code copied around is assuming properties which got removed from codegen code.  Snippets like this currently are dead code, fix yet to be done (so template code kept for consistency in templates)
    {% if method.type %}
    return {{ method.default_return_value }};
    {% endif %}
  `type` should be `returnType` these days, and `default_return_value` once got removed without replacement, might need to be done via the grantlee filter similar to filter `arg_type`.
  But the templates themselves in the patch here should be fine also once the regressions are fixed.

  R32 KDevelop


To: kossebau, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171130/e43e426c/attachment.html>

More information about the KDevelop-devel mailing list