D9034: Do not crash if there is still pending connections

[waldo cancino]

wcancino added a comment.


  Well, I did some experiments and I think I got it why it was coded like that, and why the patch is correct (depending on what behavoiur was intended by original author):
  
  IMHO, the original intention was for the following case:
  
  - Let start the debug of some php script,
  - As multiconnection is allowed, another instance of such script can be launched waiting to be debugged.
  - As soon as the first script finished,  debugger enter to NonStarted state and  he second script can be debugged ( and it will stops on the break points defined).
  
  The problem was  the debugger reamined in NonStarted state even if pending connections. Side effect, "Debug launch" button is enable, as "NonStarted"
  state allows it, and then Kdevelop crashed.
  
  We can fixed as well if we put a EndedState for any case, but in that case, if a second connection is waiting, it will simply not debug.

REPOSITORY
  R68 KDevelop XDebug Support

REVISION DETAIL
  https://phabricator.kde.org/D9034

To: wcancino, kfunk
Cc: brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171129/2c32cc9b/attachment-0001.html>