D9035: Properly launch Web Browser as detached process and handle errors if ocurred

[Sven Brauch]

brauch requested changes to this revision.
brauch added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> debugjob.cpp:357
> +
> +void XDebugBrowserJob::processError(QProcess::ProcessError error)
> +{

where do you connect to this slot ...? It seems like it is only ever called explicitly with QProcess::FailedToStart as the error, which is a bit unintuitive.

> debugjob.cpp:359
> +{
> +    qWarning() << "Cannot start application" << m_browser << " error "  << error;
> +    if (error == QProcess::FailedToStart) {

use qCWarning / qCDebug

REPOSITORY
  R68 KDevelop XDebug Support

REVISION DETAIL
  https://phabricator.kde.org/D9035

To: wcancino, kfunk, brauch
Cc: brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171128/b902e65e/attachment-0001.html>