D9016: remove global statics

Anthony Fieroni noreply at phabricator.kde.org
Tue Nov 28 05:10:36 UTC 2017


anthonyfieroni added inline comments.

INLINE COMMENTS

> helpers.cpp:382
>      foreach (QString correctionFileDir, correctionFileDirs) {
>          foreach ( const QUrl& basePath, Helper::getSearchPaths(QUrl()) ) {
>              if ( ! basePath.isParentOf(document) ) {

You gain mutex at line 377 here it's deadlock, QBasicMutex is not recursive.

REVISION DETAIL
  https://phabricator.kde.org/D9016

To: brauch, flherne
Cc: anthonyfieroni, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171128/c946253a/attachment.html>


More information about the KDevelop-devel mailing list