D9016: remove global statics
noreply at phabricator.kde.org
Mon Nov 27 12:35:28 UTC 2017
brauch created this revision.
brauch added a reviewer: flherne.
Restricted Application added a subscriber: kdevelop-devel.
Having looked at https://bugs.kde.org/show_bug.cgi?id=385107 for a while, it seems to me like compilers do really strange things™ when having multiple nontrivially constructed global static variables in a threaded environment. Probably the best solution is to simply remove all the global statics, and use free functions instead. While we're at it, I turned the Helper class into a namespace, it only has static member functions anyways.
All this code needs lots of refactoring and cleanup other than this change, but we have to start somewhere ...
Tests pass. Bug 385107 is untestable because it's super rare.
R53 KDevelop: Python Support
To: brauch, flherne
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel