D9016: remove global statics

[Sven Brauch]

brauch created this revision.
brauch added a reviewer: flherne.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  Having looked at https://bugs.kde.org/show_bug.cgi?id=385107 for a while, it seems to me like compilers do really strange things™ when having multiple nontrivially constructed global static variables in a threaded environment. Probably the best solution is to simply remove all the global statics, and use free functions instead. While we're at it, I turned the Helper class into a namespace, it only has static member functions anyways.
  
  All this code needs lots of refactoring and cleanup other than this change, but we have to start somewhere ...

TEST PLAN
  Tests pass. Bug 385107 is untestable because it's super rare.

REPOSITORY
  R53 KDevelop: Python Support

REVISION DETAIL
  https://phabricator.kde.org/D9016

AFFECTED FILES
  duchain/helpers.cpp
  duchain/helpers.h
  projectconfig/projectconfigpage.cpp
  pythonparsejob.cpp

To: brauch, flherne
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171127/b0d319f6/attachment.html>