D8492: Make SourceFormatter plugins enablable, hide actions with no plugins

[Kevin Funk]

kfunk accepted this revision.
kfunk added a comment.


  Please wait for Milian to give a +1, too

INLINE COMMENTS

> sourceformattercontroller.cpp:184
> +{
> +    ISourceFormatter* sourceFormatter = plugin->extension<ISourceFormatter>();
> +    if (sourceFormatter) {

Minor: Would prefer early-return here.

  if (!sourceFormatter) {
      return;
  }

> sourceformattercontroller.cpp:200
> +{
> +    ISourceFormatter* sourceFormatter = plugin->extension<ISourceFormatter>();
> +    if (sourceFormatter) {

Dito

> sourceformatterselectionedit.cpp:253
> +
> +    foreach (const QString& name, d->languages.keys()) {
> +        if( !sortedLanguages.contains( name ) )

Minor: Odd coding style

> mwolff wrote in kdevcustomscript.json:31
> unrelated? different patch?

+1. Push separately.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D8492

To: kossebau, #kdevelop, kfunk, mwolff
Cc: mwolff, kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171123/f11bac35/attachment.html>