D8951: CMakeLists.txt: Append KF5 macros to CMAKE_AUTOMOC_MACRO_NAMES

Kevin Funk noreply at phabricator.kde.org
Wed Nov 22 15:40:17 UTC 2017


kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.


  LGTM.
  
  @apol Yes. Ideally this should go to ECM; but we also need a fix for KDevelop using older ECM.

INLINE COMMENTS

> CMakeLists.txt:14
>  set(CMAKE_MODULE_PATH ${KDevelop_SOURCE_DIR}/cmake/modules ${ECM_MODULE_PATH})
>  
> +if(NOT ${CMAKE_VERSION} VERSION_LESS "3.10.0")

`CMAKE_VERSION` (without `${}`) is enough

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D8951

To: flherne, #kdevelop, kfunk
Cc: kfunk, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171122/7886fb0e/attachment.html>


More information about the KDevelop-devel mailing list