D8906: Do not create parse jobs while the background parser is suspended
Milian Wolff
noreply at phabricator.kde.org
Sun Nov 19 17:28:50 UTC 2017
mwolff created this revision.
Restricted Application added a subscriber: kdevelop-devel.
REVISION SUMMARY
Suspending only stopped the timer and suspended the thread weaver
queue. This is not enough: When startTimer is called the next time,
e.g. via ::addDocument, it would still trigger a call of
parseDocumentsInternal and eventually the creation of a parse job.
That one wouldn't be able to start working, as the queue is suspended.
But for clang parse jobs, it would already try to look for the
foreground parse environment (i.e. include paths and such). A future
patch will suspend the background parser while the core is being
initialized, which ensures that we won't create parse jobs with
broken environments at startup.
REPOSITORY
R32 KDevelop
REVISION DETAIL
https://phabricator.kde.org/D8906
AFFECTED FILES
kdevplatform/language/backgroundparser/backgroundparser.cpp
kdevplatform/language/backgroundparser/tests/test_backgroundparser.cpp
kdevplatform/language/backgroundparser/tests/test_backgroundparser.h
To: mwolff
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171119/cff7aa47/attachment.html>
More information about the KDevelop-devel
mailing list