D8897: VCS History dialog: show commit message with clickable urls & fixed font
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Sun Nov 19 16:52:58 UTC 2017
kossebau added a comment.
In https://phabricator.kde.org/D8897#169568, @brauch wrote:
> Very good to have somebody working on those dialogs, they really need some love. Thanks!
Yes, they really feel strange, and possibly need a bigger overhaul in general, to match workflows (mines are not yet met). This is more a by-drive improvement while I look into getting the annotation delegate to show what I want :)
> Only question is, do we really need KTextToHtml to just set a fixed font? Can we not simply set a fixed font as the font of the text browser?
Ehm, the KTextToHtml is used to transform all the urls into mark-uped hyperlinks, so QTextBrowser actually displays them as links (see https://api.kde.org/frameworks/kcoreaddons/html/namespaceKTextToHTML.html). Found this method when looking how KDE PIM's messagelib turns plain text into enriched HTML, which calls it.
And while passing in potential HTML text anway, the <tt> felt more normal, as it would spare the code to look-up the system UI font set for fixed-size fonts, incl. ensuring an update of the font if systemsettings change. So with this in mind, would you still prefer some setFont()?
BTW, in an utopian future there will be also text processor plugins which turn "BUG:xyz," "REVIEW:abc" & Co. into clickable links, perhaps even with enriched metadata pulled from the server.
To: kossebau, #kdevelop
Cc: brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel