D8857: work around clang bug 35333: don't crash when switching git branches

Kevin Funk noreply at phabricator.kde.org
Thu Nov 16 23:19:53 UTC 2017


kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.


  Also fixes^Wworks-around https://bugs.kde.org/show_bug.cgi?id=358205 -- needs `BUG:` and `FIXED-IN:`

INLINE COMMENTS

> builder.cpp:949
>      if (setComment)
> +#if CINDEX_VERSION_MINOR > 100 // FIXME https://bugs.llvm.org/show_bug.cgi?id=35333
>          decl->setComment(makeComment(clang_Cursor_getParsedComment(cursor)));

Just for symmetry: use `< 100` here, too...

> parsesession.cpp:82
> +#if CINDEX_VERSION_MINOR < 100 // FIXME https://bugs.llvm.org/show_bug.cgi?id=35333
> +        if ( argument == documentation ) {
> +            argument.clear();

Please adhere to coding style :)

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D8857

To: brauch, #kdevelop, kfunk, mwolff
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171116/ccba8b2e/attachment.html>


More information about the KDevelop-devel mailing list