D8492: Make SourceFormatter plugins enablable, hide actions with no plugins

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Thu Nov 16 21:32:02 UTC 2017

kossebau added inline comments.


> kfunk wrote in sourceformattercontroller.cpp:192
> Shouldn't this be `>= 1`?

`== 1` only. Because for > 1 the actions should have been already enabled before, no state change when there are more than one plugin. Unless things are flawed elsewhere,, which they should not :)
would you prefer better safe-then-sorry logic instead?

> kfunk wrote in sourceformattercontroller.cpp:192
> Would factor this out into a separate function (i.e. `resetUi()` as you did in the other class) and use that from both `pluginLoaded` and `unloadingPlugin`.

`resetUi()` done as proposed.

  R32 KDevelop


To: kossebau, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171116/b896ab02/attachment.html>

More information about the KDevelop-devel mailing list