D8805: fix "none" being set as default compiler on windows

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.


  idea lgtm in general, but please cleanup the implementation

INLINE COMMENTS

> compilerprovider.cpp:182
>      auto rt = ICore::self()->runtimeController()->currentRuntime();
> -    const auto path = QFile::decodeName(rt->getenv("PATH")).split(':');
> +    QChar delim = QChar(':');
> +#ifdef Q_OS_WIN

use http://doc.qt.io/qt-5/qdir.html#listSeparator

i.e.:

  const auto path = QFile::decodeName(rt->getenv("PATH"))
                        .split(QDir::listSeparator());

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D8805

To: geetamc, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171114/3475acd4/attachment.html>