D8579: KDevelop: project filter support in the abstractfilemanagerplugin import benchmark

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.


  instead of using a friend, do what the other tests do - inherit from the ProjectController, make addProject public, then set your custom controller on the core.

INLINE COMMENTS

> abstractfilemanagerpluginimportbenchmark.cpp:70
> +        ProjectController *projectController = qobject_cast<ProjectController*>(m_core->projectController());
> +        if (projectController) {
> +            projectController->addProject(m_project);

assert the project controller, always add the project, remove the else branch

> abstractfilemanagerpluginimportbenchmark.cpp:141
> +    auto core = TestCore::initialize();
> +    // attempt to load the "Project Filter" plugin;
> +    core->pluginController()->allPluginsForExtension(QStringLiteral("org.kdevelop.IProjectFilter"));

why is this required to be done explictly? add a comment

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D8579

To: rjvbb, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171113/9699ad2f/attachment.html>