D8709: [WIP] Add VcsAnnotationItemDelegate, for control of rendering, menus and tooltip
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Wed Nov 8 12:11:38 UTC 2017
kossebau added a comment.
In https://phabricator.kde.org/D8709#165692, @brauch wrote:
> Looks cool! The panel is extremely wide, maybe we want it to be a bit less wide ...?
Which width to use seems a challenge. No good idea yet, see first item in "Yet to be solved:" and the comments in `VcsAnnotationItemDelegate::sizeHint()`.
There are surely different use-cases where different width are useful:
So far my main testing use-case has been: understanding history of some code, and there the more I could see from the first line, the better, no need to go hunting for the tooltip. (And yes, I have a tiny laptop screen, 1366 px wide :) ). So goal of the width is: no need for tooltip, thus wide is better.
But if using the annotation bar together with tool views on both sides, too little source code text is seen (with my screen), so there it fails.
Sometimes one might be only interested in the grouping of committed lines, where the content on the annotation bar is more used as id to see if the lines belong to the same. There a short width, with unique enough content would be sufficient.
To be discussed. At least the delegate will allow to adjust to our needs, without having to go back to change KTextEditor API (ideally).
Cc: brauch, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel