D8653: Ignore unrecognized files in CompilerProvider
Milian Wolff
noreply at phabricator.kde.org
Mon Nov 6 12:28:49 UTC 2017
mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.
lgtm, but you can simplify the code by writing `return {};` in both places. Also, it doesn't hurt to add a short comment saying something like you do in your commit message
REPOSITORY
R32 KDevelop
BRANCH
ignore-other
REVISION DETAIL
https://phabricator.kde.org/D8653
To: aaronpuchert, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171106/f45cdb00/attachment.html>
More information about the KDevelop-devel
mailing list