D8588: Make VCS data container classes implicitly shared
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Fri Nov 3 00:09:36 UTC 2017
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
I agree this is better.
Let's be more liberal with reviews? I just saw 2 reviews whose end was to remove tests.
Let's agree that verbosity in tests isn't the worst in life, we have _very_ bard code in KDevelop, these tests aren't close by far.
And thanks @kossebau for taking the time to take our codebase steps forward little by little.
To: kossebau, #kdevelop, apol
Cc: apol, mwolff, brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel