D8579: KDevelop: project filter support in the abstractfilemanagerplugin import benchmark
noreply at phabricator.kde.org
Thu Nov 2 13:59:26 UTC 2017
mwolff added inline comments.
> rjvbb wrote in abstractfilemanagerpluginimportbenchmark.cpp:67
> It replaces a full-blown ProjectController initialisation, and tells the ProjectFilterProvider to set up the project filter. Without that signal, the filter doesn't do its full job (it only filters out the .kdev4 directories).
> I tried setting up the ProjectController, but got crashes while plugins were being loaded that aren't of interest anyway, and in addition we'd have to import the test projects through the ProjectController in order for it to send out that signal. I don't think we want that here.
hm, I'd prefer using the actual controller setup as that is less brittle. I.e. if anything changes in the future, this will silently break, most probably.
> rjvbb wrote in abstractfilemanagerpluginimportbenchmark.cpp:131
> I suppose it should indeed never happen. The call itself is required though (I checked again), and if it fails it will do so quietly and results will be for project import without filtering. I wouldn't mind putting an assert here, but a version that doesn't disappear in release builds.
I'd say remove it
To: rjvbb, #kdevelop
Cc: mwolff, kdevelop-devel, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel