D6050: Use explicit flag values or explicit constructor instead of nullptr

[Friedrich W. H. Kossebau]

kossebau created this revision.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  The constructor of QFlags which was intended to handle literal "0"
  as commonly used indicator of no-flags-set has been done with a
  trick based on pointer types. Which these days of nullptr existing and
  compilers pushing to use that sadly fired back and, instead of
  allowing convenient code with commonly understood literal "0" values,
  resulted in quite some code using "nullptr" to indicate a QFLags-based
  type value with no flags set, which can be puzzling for humans
  reading the code
  
  To improve the code again IMHO, instead of "nullptr" are used:
  
  - enum item representing the 0=no-flag-set value, if existing
  - explicit constructor (or {} for default arg values, given arg type is aöready noted as part of arg definition)

REPOSITORY
  R33 KDevPlatform

BRANCH
  nonullptrforflagsplease

REVISION DETAIL
  https://phabricator.kde.org/D6050

AFFECTED FILES
  debugger/breakpoint/breakpointmodel.cpp
  debugger/util/treemodel.cpp
  interfaces/idocumentcontroller.h
  project/projectmodel.cpp
  shell/documentcontroller.h
  sublime/aggregatemodel.cpp

To: kossebau, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170531/187727b0/attachment.html>