D6038: Improve ConfigDialog API for adding pages, follow list API patterns

[Friedrich W. H. Kossebau]

kossebau created this revision.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  The old API had a single method "add" which then by the second parameter
  being a nullptr or not decided whether to insert before that page
  as given by the second parameter or append at the end.
  This confused code readers a little, so splitting into
  two distinct methods following std list API conventions
  ("append(x)" vs. "insert(before, x)") should improve things,
  even if at the cost of an additional symbol.

REPOSITORY
  R33 KDevPlatform

BRANCH
  improveConfigDialogAPI

REVISION DETAIL
  https://phabricator.kde.org/D6038

AFFECTED FILES
  shell/configdialog.cpp
  shell/configdialog.h
  shell/projectcontroller.cpp
  shell/uicontroller.cpp

To: kossebau, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170530/18e8ecc2/attachment.html>