D6022: Add separate category for "Runtimes" in settings and module listing
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Tue May 30 13:36:57 UTC 2017
kossebau added inline comments.
INLINE COMMENTS
> apol wrote in uicontroller.cpp:537
> These two look swapped. Can you check?
What do you mean by swapped? Actually the whole old code here is screwed, as the API dox of `ConfigDialog::addConfigPage(ConfigPage* page, ConfigPage* next = nullptr)` claims something else than what the implementation does (signature also changes from `next` to `previous`.
But the added code follows the pattern, and the runtime result seems okay.
I stayed away from changing this for this patch, only planned to handle that as future patch.
REPOSITORY
R33 KDevPlatform
BRANCH
addcategoryforruntimes
REVISION DETAIL
https://phabricator.kde.org/D6022
To: kossebau, #kdevelop, apol
Cc: apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170530/cf0157ff/attachment.html>
More information about the KDevelop-devel
mailing list