D6012: Add asserts to some TokenStreamBase methods, protect against out-of-bounds
Kevin Funk
noreply at phabricator.kde.org
Mon May 29 15:15:39 UTC 2017
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
+1, but please add the other asserts, too
INLINE COMMENTS
> kdev-pg-token-stream.h:199
> {
> return mTokenBuffer.back();
> }
assert non-empty?
> kdev-pg-token-stream.h:207
> {
> return mTokenBuffer.front();
> }
dito
REPOSITORY
R51 KDevelop: PG Qt
BRANCH
addasserts
REVISION DETAIL
https://phabricator.kde.org/D6012
To: kossebau, #kdevelop, kfunk
Cc: kfunk, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170529/d3d052f2/attachment.html>
More information about the KDevelop-devel
mailing list