D5995: Fix CompilerFilterStrategy::errorInLine() to handle paths with whitespace
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Sun May 28 01:27:20 UTC 2017
kossebau created this revision.
Restricted Application added a subscriber: kdevelop-devel.
REVISION SUMMARY
The "([^: \\t]+):" does not match strings with white space. While this
reduces the chance of wrong matches, it also excludes valid ones for
paths with white space in them (like on new KDE CI).
The different regex for the different tools are a bit inconsistent on that
matter, so as consistent solution whitespaces in paths are supported.
Separate commit for the fixes of the missing double escape for \t (?)
TEST PLAN
test_filteringstrategy no longer fails when sources are below a path
with white spaces. And cmake/gcc errors in projects with such paths
are now also properly supported.
REPOSITORY
R33 KDevPlatform
BRANCH
fixRegExpFor_errorInLine
REVISION DETAIL
https://phabricator.kde.org/D5995
AFFECTED FILES
outputview/outputfilteringstrategies.cpp
To: kossebau, #kdevelop, volden
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170528/cb063a7f/attachment-0001.html>
More information about the KDevelop-devel
mailing list