D5915: Infer correct type from 'and' / 'or' expressions
noreply at phabricator.kde.org
Sat May 20 00:54:21 UTC 2017
nalvarez marked 2 inline comments as done.
nalvarez added inline comments.
> flherne wrote in expressionvisitor.cpp:736
> Nitpick - convention for these is either just `v` or `operandVisitor` (the latter usually when then there's more than one). I don't have a strong opinion.
Renamed, mainly for consistency with the other methods which use `v`.
> flherne wrote in pyduchaintest.cpp:510
> Nitpick - you can use single quotes for the Python strings, instead of backslashed double-quotes. They're semantically identical.
Good point! Changed.
R53 KDevelop: Python Support
To: nalvarez, brauch, flherne
Cc: flherne, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel