D5915: Infer correct type from 'and' / 'or' expressions

[Nicolás Alvarez]

nalvarez marked 2 inline comments as done.
nalvarez added inline comments.

INLINE COMMENTS

> flherne wrote in expressionvisitor.cpp:736
> Nitpick - convention for these is either just `v` or `operandVisitor` (the latter usually when then there's more than one). I don't have a strong opinion.

Renamed, mainly for consistency with the other methods which use `v`.

> flherne wrote in pyduchaintest.cpp:510
> Nitpick - you can use single quotes for the Python strings, instead of backslashed double-quotes. They're semantically identical.

Good point! Changed.

REPOSITORY
  R53 KDevelop: Python Support

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5915

To: nalvarez, brauch, flherne
Cc: flherne, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170520/02509e0c/attachment.html>