D5707: Normalize line endings when creating ParseJob from background file.

Milian Wolff noreply at phabricator.kde.org
Thu May 4 13:48:37 UTC 2017


mwolff added a comment.


  ugh. I see it's a necessary evil. But I think it's actually going to be faster to either hand roll this replacement or use a QRegularExpression, because your code is now scanning the contents twice. Once should be enough. And a greedy pattern like `"\\r\\n??"` should be quite fast.

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D5707

To: flherne, brauch, #kdevelop
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170504/a553f804/attachment-0001.html>


More information about the KDevelop-devel mailing list