D5703: Add support for variadic functions.

[Milian Wolff]

mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  lgtm, two parts can be cleaned up but otherwise feel free to commit

INLINE COMMENTS

> declarationbuilder.cpp:767
> +{
> +    ParameterAst *oldArg = m_functionDeclarationPreviousArgument;
> +    m_functionDeclarationPreviousArgument = 0;

you could use PushValue or QScopedValueRollback here

> declarationbuilder.cpp:802
> +    if (m_functionDeclarationPreviousArgument && m_functionDeclarationPreviousArgument->isVariadic != -1)
> +    {
> +        reportError(i18n("Only the last parameter can be variadic."), m_functionDeclarationPreviousArgument);

put on previous line

REPOSITORY
  R52 KDevelop: PHP Support

BRANCH
  splat

REVISION DETAIL
  https://phabricator.kde.org/D5703

To: pprkut, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170503/fb2eb8f8/attachment-0001.html>