D5139: VCS commit message width feedback

René J.V. Bertin noreply at phabricator.kde.org
Tue Mar 28 09:17:39 UTC 2017


rjvbb added a comment.


  In https://phabricator.kde.org/D5139#98282, @mwolff wrote:
  
  > I'm still against messing with the font styles the way you do it. simply add underlines for the part that is longer than N chars and add a tooltip for that part such that people know what's happening
  
  
  And I'm still against using underlining in this context so I'd like to have Aleix's refreshed opinion as well. In any case I will only make that change if it makes it easier to patch the code to use my current solution in my KDevelop packages.
  
  I recall trying to change the underlining style instead of colour but hitting the same limitation, i.e. the whole underlined section changed style. That's not acceptable to me.
  
  BTW, letter spacing is not a font style, it's a text property. Just like line width.
  
  Setting a tooltip on part of a line? I don't know if that's even possible and one of the reasons I added a tooltip to another element is that text tooltips are too unlikely (and frankly difficult) to be triggered reliably.
  
  > and an overflow in length should never get a red underline, it's not an error, just a warning / suggestion
  
  Well, tell that to the original author.

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D5139

To: rjvbb, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel, #kdevelop, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170328/abd3450d/attachment-0001.html>


More information about the KDevelop-devel mailing list