D5183: Reopen accidentally closed tab

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Would be a useful additions, I know I would have used it before :)

INLINE COMMENTS

> mainwindow.cpp:519
>  
> -void MainWindow::newTabRequested()
> +void MainWindow::newTabRequested(const QUrl& file = QUrl())
>  {

Default argument values should be only in the declaration, no? At least my current and past compilers refuse to take such code, referring to -fpermissive. Hm, or only if both method declaration and definition have a default argument set?

What is the purpose of a default argument value only in the definition? Especially when installed headers will miss that info bit about the default argument value?
I have never seen this before.

REVISION DETAIL
  https://phabricator.kde.org/D5183

To: coopht, mwolff, #kdevelop
Cc: kossebau, mwolff, brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170327/236cd931/attachment.html>