D5183: Reopen accidentally closed tab

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.


  I like the change in general, only wonder whether we need to introduce a new queue for that - can't we reuse the recent file mechanism instead? or do people really want to have an infinite history here?
  
  browsers btw have this feature too, but they probably rely on their history feature for this purpose, right?

INLINE COMMENTS

> mainwindow.cpp:519
>  
> -void MainWindow::newTabRequested()
> +void MainWindow::newTabRequested(const QUrl & file)
>  {

dito

> mainwindow.h:97
>      void dockBarContextMenuRequested(Qt::DockWidgetArea, const QPoint&) override;
> -    void newTabRequested() override;
> +    void newTabRequested(const QUrl & file = QUrl()) override;
>  

remove space before &

> mainwindow_actions.cpp:192
>  
> +void MainWindowPrivate::fileOpen(const QUrl & file)
> +{

dito

> mainwindow_p.h:88
>      void fileNew();
> +    void fileOpen(const QUrl & fileName);
>  

dito

> container.cpp:124
>  Q_SIGNALS:
> -    void newTabRequested();
> +    void newTabRequested(const QUrl & file = QUrl());
>  

dito

> container.cpp:361
>  
> +void Container::addToReopenQueue (QWidget *w)
> +{

remove space before (

> container.cpp:367
> +        if (urlDocument && !urlDocument->url().isEmpty()) {
> +            d->reopenFilesQueue.enqueue(urlDocument->url());
> +        }

this could potentially end up storing tons of items... I wonder - could we instead rely on the "recent files" mechanism and only support reopening the last N items through that?

> container.h:22
>  
> +#include <QUrl>
>  #include <QWidget>

forward-declare instead of include

> container.h:88
>       */
> -    void newTabRequested();
> +    void newTabRequested(const QUrl & file = QUrl());
>      void tabContextMenuRequested(Sublime::View* view, QMenu* menu);

dito

> mainwindow.cpp:416
>  
> -void MainWindow::newTabRequested()
> +void MainWindow::newTabRequested(const QUrl & file)
>  {

dito

> mainwindow.h:144
>      virtual void tabToolTipRequested(Sublime::View* view, Sublime::Container* container, int tab);
> -    virtual void newTabRequested();
> +    virtual void newTabRequested(const QUrl & file = QUrl());
>      /**Called whenever the user requests a context menu on a dockwidget bar.

remove space before &

REVISION DETAIL
  https://phabricator.kde.org/D5183

To: coopht, #kdevelop, mwolff
Cc: mwolff, brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170326/e89e8b3c/attachment-0001.html>