D5183: Reopen accidentally closed tab

Alexander Basov noreply at phabricator.kde.org
Sun Mar 26 19:34:20 UTC 2017


coopht marked an inline comment as done.
coopht added inline comments.

INLINE COMMENTS

> brauch wrote in container.cpp:365
> there is no point in using qobject_cast over static_cast if you don't check the result; not sure if you need to?

I will result check here.

> brauch wrote in mainwindow_p.cpp:136
> I suggest Ctrl+Shift+T, like in Firefox for example. I think meta is weird for shortcuts, it is not used anywhere else.

I use Meta+T because Ctrl+Shit+T is already in use by Split View Top/Bottom action. 
Should I change default shortcut for Split View Top/Bottom action ?

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D5183

To: coopht, #kdevelop
Cc: brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170326/9adb796d/attachment.html>


More information about the KDevelop-devel mailing list