D5159: Remove unused Qt::WindowFlags parameters from internal API

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Fri Mar 24 00:20:55 UTC 2017


kossebau added a comment.


  In https://phabricator.kde.org/D5159#97250, @apol wrote:
  
  > In https://phabricator.kde.org/D5159#97239, @kfunk wrote:
  >
  > > I know why you did that! ;)
  >
  >
  > Now I want to know too.
  
  
  He watched me last summer ;)
  
  Na, it's rather this: marking these code lines, which have `flags = nullptr` inside, as unused and thus removing them is a gentle solution to reduce the number of objects where Kevin and I have different ideas about, or, at least, where I currently got over-sensitive about when seeing such "logic" ;) For background see https://phabricator.kde.org/D3987#78257 ff.
  
  > +1 on the patch, thanks!
  
  Thanks both for instant review.

REPOSITORY
  R33 KDevPlatform

BRANCH
  removeUnusedWindowFlagParameter

REVISION DETAIL
  https://phabricator.kde.org/D5159

To: kossebau, #kdevelop, kfunk
Cc: apol, kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170324/d05309b3/attachment-0001.html>


More information about the KDevelop-devel mailing list