D5129: QtWebKit documentation regression fixes

Igor Kushnir noreply at phabricator.kde.org
Wed Mar 22 15:32:45 UTC 2017


igorkushnir added a comment.


  Note that there are other recent regressions with both QtWebKit and QtWebEngine implementations.
  
  1. `setDelegateLinks` leaks memory if called more than once in QtWebEngine implementation because its parent is not a `QWebEngineView` (https://doc.qt.io/qt-5/qwebengineview.html#setPage).
  2. The `StandardDocumentationView::linkClicked` signal is never emitted. I don't understand how `PageInterceptor` was intended to work.
  3. Some lines of code in documentation plugins were simply removed in a recent KDevelop commit. At least some of those changes cause regressions as well.

REPOSITORY
  R33 KDevPlatform

BRANCH
  webkit-documentation-fixes

REVISION DETAIL
  https://phabricator.kde.org/D5129

To: igorkushnir, kfunk
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170322/43fd2556/attachment.html>


More information about the KDevelop-devel mailing list